contrib/buildsystems: error out on unknown option

dscho · gitster · commit 66697467f825 · 2019-07-29T14:51:42.000-07:00
One time too many did this developer call the `generate` script passing
a `--make-out=&lt;PATH&gt;` option that was happily ignored (because there
should be a space, not an equal sign, between `--make-out` and the
path).

And one time too many, this script not only ignored it but did not even
complain. Let's fix that.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
@@ -57,6 +57,8 @@ sub showUsage
         open(F, "<$infile") || die "Couldn't open file $infile";
         @makedry = <F>;
         close(F);
+    } else {
+        die "Unknown option: " . $arg;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ sub showUsage`
`57`	`57`	`open(F, "<$infile") \|\| die "Couldn't open file $infile";`
`58`	`58`	`@makedry = <F>;`
`59`	`59`	`close(F);`
	`60`	`+ } else {`
	`61`	`+ die "Unknown option: " . $arg;`
`60`	`62`	`}`
`61`	`63`	`}`
`62`	`64`