push: only get the branch when needed

felipec · gitster · commit 65c63a005434 · 2021-06-02T10:12:01.000+09:00
Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/push.c b/builtin/push.c
@@ -243,7 +243,7 @@ static int is_same_remote(struct remote *remote)
 
 static void setup_default_push_refspecs(struct remote *remote)
 {
-	struct branch *branch = branch_get(NULL);
+	struct branch *branch;
 	int same_remote = is_same_remote(remote);
 
 	switch (push_default) {
@@ -259,6 +259,7 @@ static void setup_default_push_refspecs(struct remote *remote)
 		break;
 	}
 
+	branch = branch_get(NULL);
 	if (!branch)
 		die(_(message_detached_head_die), remote->name);
 

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ static int is_same_remote(struct remote *remote)`
`243`	`243`
`244`	`244`	`static void setup_default_push_refspecs(struct remote *remote)`
`245`	`245`	`{`
`246`		`- struct branch *branch = branch_get(NULL);`
	`246`	`+ struct branch *branch;`
`247`	`247`	`int same_remote = is_same_remote(remote);`
`248`	`248`
`249`	`249`	`switch (push_default) {`
`@@ -259,6 +259,7 @@ static void setup_default_push_refspecs(struct remote *remote)`
`259`	`259`	`break;`
`260`	`260`	`}`
`261`	`261`
	`262`	`+ branch = branch_get(NULL);`
`262`	`263`	`if (!branch)`
`263`	`264`	`die(_(message_detached_head_die), remote->name);`
`264`	`265`