contrib/credential/netrc: work outside a repo

Denton-L · gitster · commit 6579d93a9789 · 2019-12-20T12:40:52.000-08:00
Currently, git-credential-netrc does not work outside of a git
repository. It fails with the following error:

	fatal: Not a git repository: . at /usr/share/perl5/Git.pm line 214.

There is no real reason why need to be within a repository, though.
Credential helpers should be able to work just fine outside the
repository as well.

Call the non-self version of config() so that git-credential-netrc no
longer needs to be run within a repository.

Signed-off-by: Denton Liu &lt;liu.denton@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/credential/netrc/git-credential-netrc.perl b/contrib/credential/netrc/git-credential-netrc.perl
@@ -423,7 +423,7 @@ sub load_config {
 	# load settings from git config
 	my $options = shift;
 	# set from command argument, gpg.program option, or default to gpg
-	$options->{'gpg'} //= Git->repository()->config('gpg.program')
+	$options->{'gpg'} //= Git::config('gpg.program')
 	                  // 'gpg';
 	log_verbose("using $options{'gpg'} for GPG operations");
 }

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,7 @@ sub load_config {`
`423`	`423`	`# load settings from git config`
`424`	`424`	`my $options = shift;`
`425`	`425`	`# set from command argument, gpg.program option, or default to gpg`
`426`		`- $options->{'gpg'} //= Git->repository()->config('gpg.program')`
	`426`	`+ $options->{'gpg'} //= Git::config('gpg.program')`
`427`	`427`	`// 'gpg';`
`428`	`428`	`log_verbose("using $options{'gpg'} for GPG operations");`
`429`	`429`	`}`