Fix truncated usage messages

bjorng · gitster · commit 625a860cb73b · 2009-11-22T16:14:48.000-08:00
The usage messages for some commands (such as 'git diff-tree') are truncated because they don't fit in a fixed buffer of 1024 bytes. It would be tempting to eliminate the buffer and the problem once and for all by doing the output in three steps, but doing so could (according to commit d048a96) increase the likelyhood of messing up the display. So we just increase the size of the buffer. Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/usage.c b/usage.c
@@ -7,7 +7,7 @@
 
 static void report(const char *prefix, const char *err, va_list params)
 {
-	char msg[1024];
+	char msg[4096];
 	vsnprintf(msg, sizeof(msg), err, params);
 	fprintf(stderr, "%s%s\n", prefix, msg);
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`static void report(const char prefix, const char err, va_list params)`
`9`	`9`	`{`
`10`		`- char msg[1024];`
	`10`	`+ char msg[4096];`
`11`	`11`	`vsnprintf(msg, sizeof(msg), err, params);`
`12`	`12`	`fprintf(stderr, "%s%s\n", prefix, msg);`
`13`	`13`	`}`