Use strlcpy instead of strncpy in mailmap.c

raalkml · Junio C Hamano · commit 600682aaa12c · 2007-04-30T16:57:47.000-07:00
strncpy does not NUL-terminate output in case of output buffer too short,
and map_email prototype (and usage) does not allow for figuring out
what the length of the name is.

Signed-off-by: Alex Riesen &lt;raa.lkml@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/mailmap.c b/mailmap.c
@@ -80,7 +80,7 @@ int map_email(struct path_list *map, const char *email, char *name, int maxlen)
 		free(mailbuf);
 	if (item != NULL) {
 		const char *realname = (const char *)item->util;
-		strncpy(name, realname, maxlen);
+		strlcpy(name, realname, maxlen);
 		return 1;
 	}
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ int map_email(struct path_list map, const char email, char *name, int maxlen)`
`80`	`80`	`free(mailbuf);`
`81`	`81`	`if (item != NULL) {`
`82`	`82`	`const char realname = (const char )item->util;`
`83`		`- strncpy(name, realname, maxlen);`
	`83`	`+ strlcpy(name, realname, maxlen);`
`84`	`84`	`return 1;`
`85`	`85`	`}`
`86`	`86`	`return 0;`