t4119-apply-config.sh: use the $( ... ) construct for command substitution

devzero2000 · gitster · commit 6003eb13c695 · 2014-04-30T11:08:09.000-07:00
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`$.*$`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/t4119-apply-config.sh b/t/t4119-apply-config.sh
@@ -68,7 +68,7 @@ test_expect_success 'apply --whitespace=strip from config' '
 	check_result sub/file1
 '
 
-D=`pwd`
+D=$(pwd)
 
 test_expect_success 'apply --whitespace=strip in subdir' '
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ test_expect_success 'apply --whitespace=strip from config' '`
`68`	`68`	`check_result sub/file1`
`69`	`69`	`'`
`70`	`70`
`71`		-D=`pwd`
	`71`	`+D=$(pwd)`
`72`	`72`
`73`	`73`	`test_expect_success 'apply --whitespace=strip in subdir' '`
`74`	`74`