list-objects-filter-options: error is localizeable

matvore · gitster · commit 5c03bc8b1d1f · 2019-05-31T11:30:10.000-07:00
The "invalid filter-spec" message is user-facing and not a BUG, so make
it localizeable.

For reference, the message appears in this context:

	$ git rev-list --filter=blob:nonse --objects HEAD
	fatal: invalid filter-spec 'blob:nonse'

Signed-off-by: Matthew DeVore &lt;matvore@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
@@ -84,7 +84,7 @@ static int gently_parse_list_objects_filter(
 	}
 
 	if (errbuf)
-		strbuf_addf(errbuf, "invalid filter-spec '%s'", arg);
+		strbuf_addf(errbuf, _("invalid filter-spec '%s'"), arg);
 
 	memset(filter_options, 0, sizeof(*filter_options));
 	return 1;

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ static int gently_parse_list_objects_filter(`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`if (errbuf)`
`87`		`- strbuf_addf(errbuf, "invalid filter-spec '%s'", arg);`
	`87`	`+ strbuf_addf(errbuf, _("invalid filter-spec '%s'"), arg);`
`88`	`88`
`89`	`89`	`memset(filter_options, 0, sizeof(*filter_options));`
`90`	`90`	`return 1;`