t5550: simplify no matching line check

Denton-L · gitster · commit 5a828bcf1e1a · 2020-03-27T10:56:40.000-07:00
In the 'did not use upload-pack service' test, we have a complicated
song-and-dance to ensure that there are no "/git-upload-pack" lines in
"$HTTPD_ROOT_PATH/access.log". Simplify this by just checking that grep
returns a non-zero exit code.

Helped-by: Junio C Hamano &lt;gitster@pobox.com&gt;
Signed-off-by: Denton Liu &lt;liu.denton@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh
@@ -248,9 +248,7 @@ test_expect_success 'fetch can handle previously-fetched .idx files' '
 '
 
 test_expect_success 'did not use upload-pack service' '
-	test_might_fail grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act &&
-	: >exp &&
-	test_cmp exp act
+	! grep "/git-upload-pack" "$HTTPD_ROOT_PATH/access.log"
 '
 
 test_expect_success 'git client shows text/plain errors' '

Original file line number	Diff line number	Diff line change
`@@ -248,9 +248,7 @@ test_expect_success 'fetch can handle previously-fetched .idx files' '`
`248`	`248`	`'`
`249`	`249`
`250`	`250`	`test_expect_success 'did not use upload-pack service' '`
`251`		`- test_might_fail grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act &&`
`252`		`- : >exp &&`
`253`		`- test_cmp exp act`
	`251`	`+ ! grep "/git-upload-pack" "$HTTPD_ROOT_PATH/access.log"`
`254`	`252`	`'`
`255`	`253`
`256`	`254`	`test_expect_success 'git client shows text/plain errors' '`