git-remote: fix "Use of uninitialized value in string ne"

gitster · gitster · commit 59b2023fbb15 · 2007-10-24T18:47:50.000-07:00
martin f krafft &lt;madduck@madduck.net&gt; writes:

&gt; piper:~&gt; git remote show origin
&gt; * remote origin
&gt;   URL: ssh://git.madduck.net/~/git/etc/mailplate.git
&gt; Use of uninitialized value in string ne at /usr/local/stow/git/bin/git-remote line 248.

This is because there might not be branch.&lt;name&gt;.remote defined but
the code unconditionally dereferences $branch-&gt;{$name}{'REMOTE'} and
compares with another string.

Tested-by: Martin F Krafft &lt;madduck@madduck.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-remote.perl b/git-remote.perl
@@ -244,7 +244,8 @@ sub show_remote {
 	print "* remote $name\n";
 	print "  URL: $info->{'URL'}\n";
 	for my $branchname (sort keys %$branch) {
-		next if ($branch->{$branchname}{'REMOTE'} ne $name);
+		next unless (defined $branch->{$branchname}{'REMOTE'} &&
+			     $branch->{$branchname}{'REMOTE'} eq $name);
 		my @merged = map {
 			s|^refs/heads/||;
 			$_;
