t/gitweb-lib: Don't pass constant to decode_utf8

Benabik · gitster · commit 598df7bcb775 · 2010-10-20T13:01:33.000-07:00
Encode.pm started updating the string to decode in-place when a second
argument is passed in version 2.40.

This causes 'decode_utf8("", Encode::FB_CROAK)' to die with a message
like:

  Modification of a read-only value attempted at .../Encode.pm line 216.

Work around this by passing an empty variable instead of a constant
string.

Signed-off-by: Brian Gernhardt &lt;brian@gernhardtsoftware.com&gt;
Acked-by: Jakub Narebski &lt;jnareb@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
@@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then
 	test_done
 fi
 
-perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
+perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
     skip_all='skipping gitweb tests, perl version is too old'
     test_done
 }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then`
`80`	`80`	`test_done`
`81`	`81`	`fi`
`82`	`82`
`83`		`-perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 \|\| {`
	`83`	`+perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 \|\| {`
`84`	`84`	`skip_all='skipping gitweb tests, perl version is too old'`
`85`	`85`	`test_done`
`86`	`86`	`}`