MinGW: disable CRT command line globbing

kblees · gitster · commit 5901dc6613fc · 2014-06-16T10:56:47.000-07:00
MingwRT listens to _CRT_glob to decide if __getmainargs should
perform globbing, with the default being that it should.
Unfortunately, __getmainargs globbing is sub-par; for instance
patterns like "*.c" will only match c-sources in the current
directory.

Disable __getmainargs' command line wildcard expansion, so these
patterns will be left untouched, and handled by Git's superior
built-in globbing instead.

MSVC defaults to no globbing, so we don't need to do anything
in that case.

This fixes t5505 and t7810.

Signed-off-by: Karsten Blees &lt;blees@dcon.de&gt;
Signed-off-by: Erik Faye-Lund &lt;kusmabite@gmail.com&gt;
Signed-off-by: Stepan Kasal &lt;kasal@ucw.cz&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -1927,6 +1927,12 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t utflen)
 	return -1;
 }
 
+/*
+ * Disable MSVCRT command line wildcard expansion (__getmainargs called from
+ * mingw startup code, see init.c in mingw runtime).
+ */
+int _CRT_glob = 0;
+
 void mingw_startup()
 {
 	/* copy executable name to argv[0] */

Original file line number	Diff line number	Diff line change
`@@ -1927,6 +1927,12 @@ int xwcstoutf(char utf, const wchar_t wcs, size_t utflen)`
`1927`	`1927`	`return -1;`
`1928`	`1928`	`}`
`1929`	`1929`
	`1930`	`+/*`
	`1931`	`+ * Disable MSVCRT command line wildcard expansion (__getmainargs called from`
	`1932`	`+ * mingw startup code, see init.c in mingw runtime).`
	`1933`	`+ */`
	`1934`	`+int _CRT_glob = 0;`
	`1935`	`+`
`1930`	`1936`	`void mingw_startup()`
`1931`	`1937`	`{`
`1932`	`1938`	`/* copy executable name to argv[0] */`