gitweb: avoid warnings for commits without body

joeyh · gitster · commit 53c3967647f7 · 2008-09-18T19:48:19.000-07:00
In the unusual case when there is no commit message, gitweb would
output an uninitialized value warning.

Signed-off-by: Joey Hess &lt;joey@kitenet.net&gt;
Acked-by: Jakub Narebski &lt;jnareb@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
@@ -2092,7 +2092,7 @@ sub parse_commit_text {
 			last;
 		}
 	}
-	if ($co{'title'} eq "") {
+	if (! defined $co{'title'} || $co{'title'} eq "") {
 		$co{'title'} = $co{'title_short'} = '(no commit message)';
 	}
 	# remove added spaces

Original file line number	Diff line number	Diff line change
`@@ -2092,7 +2092,7 @@ sub parse_commit_text {`
`2092`	`2092`	`last;`
`2093`	`2093`	`}`
`2094`	`2094`	`}`
`2095`		`- if ($co{'title'} eq "") {`
	`2095`	`+ if (! defined $co{'title'} \|\| $co{'title'} eq "") {`
`2096`	`2096`	`$co{'title'} = $co{'title_short'} = '(no commit message)';`
`2097`	`2097`	`}`
`2098`	`2098`	`# remove added spaces`