print errno when reporting a system call error

pclouds · gitster · commit 5118d7f4e6e0 · 2017-05-26T12:33:56.000+09:00
Signed-off-by: Nguyễn Thái Ngọc Duy &lt;pclouds@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/log.c b/builtin/log.c
@@ -858,7 +858,8 @@ static int open_next_file(struct commit *commit, const char *subject,
 		printf("%s\n", filename.buf + outdir_offset);
 
 	if ((rev->diffopt.file = fopen(filename.buf, "w")) == NULL)
-		return error(_("Cannot open patch file %s"), filename.buf);
+		return error_errno(_("Cannot open patch file %s"),
+				   filename.buf);
 
 	strbuf_release(&filename);
 	return 0;
diff --git a/rerere.c b/rerere.c
@@ -484,13 +484,13 @@ static int handle_file(const char *path, unsigned char *sha1, const char *output
 	io.input = fopen(path, "r");
 	io.io.wrerror = 0;
 	if (!io.input)
-		return error("Could not open %s", path);
+		return error_errno("Could not open %s", path);
 
 	if (output) {
 		io.io.output = fopen(output, "w");
 		if (!io.io.output) {
 			fclose(io.input);
-			return error("Could not write %s", output);
+			return error_errno("Could not write %s", output);
 		}
 	}
 
diff --git a/xdiff-interface.c b/xdiff-interface.c
@@ -164,9 +164,9 @@ int read_mmfile(mmfile_t *ptr, const char *filename)
 	size_t sz;
 
 	if (stat(filename, &st))
-		return error("Could not stat %s", filename);
+		return error_errno("Could not stat %s", filename);
 	if ((f = fopen(filename, "rb")) == NULL)
-		return error("Could not open %s", filename);
+		return error_errno("Could not open %s", filename);
 	sz = xsize_t(st.st_size);
 	ptr->ptr = xmalloc(sz ? sz : 1);
 	if (sz && fread(ptr->ptr, sz, 1, f) != 1) {

Original file line number	Diff line number	Diff line change
`@@ -484,13 +484,13 @@ static int handle_file(const char path, unsigned char sha1, const char *output`
`484`	`484`	`io.input = fopen(path, "r");`
`485`	`485`	`io.io.wrerror = 0;`
`486`	`486`	`if (!io.input)`
`487`		`- return error("Could not open %s", path);`
	`487`	`+ return error_errno("Could not open %s", path);`
`488`	`488`
`489`	`489`	`if (output) {`
`490`	`490`	`io.io.output = fopen(output, "w");`
`491`	`491`	`if (!io.io.output) {`
`492`	`492`	`fclose(io.input);`
`493`		`- return error("Could not write %s", output);`
	`493`	`+ return error_errno("Could not write %s", output);`
`494`	`494`	`}`
`495`	`495`	`}`
`496`	`496`