diff.c: flush stdout before printing rename warnings

pclouds · gitster · commit 4e056c989f86 · 2018-01-16T14:34:20.000-08:00
The diff output is buffered in a FILE object and could still be
partially buffered when we print these warnings (directly to fd 2).
The output is messed up like this

 worktree.c                                   |   138 +-
 worktree.h        warning: inexact rename detection was skipped due to too many files.
                           |    12 +-
 wrapper.c                                    |    83 +-

It gets worse if the warning is printed after color codes for the graph
part are already printed. You'll get a warning in green or red.

Flush stdout first, so we can get something like this instead:

 xdiff/xutils.c                               |    42 +-
 xdiff/xutils.h                               |     4 +-
 1033 files changed, 150824 insertions(+), 69395 deletions(-)
warning: inexact rename detection was skipped due to too many files.

Signed-off-by: Nguyễn Thái Ngọc Duy &lt;pclouds@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/diff.c b/diff.c
@@ -4623,6 +4623,7 @@ static const char rename_limit_advice[] =
 
 void diff_warn_rename_limit(const char *varname, int needed, int degraded_cc)
 {
+	fflush(stdout);
 	if (degraded_cc)
 		warning(degrade_cc_to_c_warning);
 	else if (needed)

Original file line number	Diff line number	Diff line change
`@@ -4623,6 +4623,7 @@ static const char rename_limit_advice[] =`
`4623`	`4623`
`4624`	`4624`	`void diff_warn_rename_limit(const char *varname, int needed, int degraded_cc)`
`4625`	`4625`	`{`
	`4626`	`+ fflush(stdout);`
`4626`	`4627`	`if (degraded_cc)`
`4627`	`4628`	`warning(degrade_cc_to_c_warning);`
`4628`	`4629`	`else if (needed)`