strbuf: fix urlencode format string on signed char

j-d-r · gitster · commit 4c267f2ae37e · 2017-12-22T13:43:19.000-08:00
Git credential fails with special char in password with

    remote: Invalid username or password.
    fatal: Authentication failed for

    File ~/.git-credential contains badly urlencoded characters
    %ffffffXX%ffffffYY instead of %XX%YY.

Add a cast to an unsigned char to fix urlencode use of %02x on a
char.

Signed-off-by: Julien Dusser &lt;julien.dusser@free.fr&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/strbuf.c b/strbuf.c
@@ -658,7 +658,7 @@ static void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len,
 		    (!reserved && is_rfc3986_reserved(ch)))
 			strbuf_addch(sb, ch);
 		else
-			strbuf_addf(sb, "%%%02x", ch);
+			strbuf_addf(sb, "%%%02x", (unsigned char)ch);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ static void strbuf_add_urlencode(struct strbuf sb, const char s, size_t len,`
`658`	`658`	`(!reserved && is_rfc3986_reserved(ch)))`
`659`	`659`	`strbuf_addch(sb, ch);`
`660`	`660`	`else`
`661`		`- strbuf_addf(sb, "%%%02x", ch);`
	`661`	`+ strbuf_addf(sb, "%%%02x", (unsigned char)ch);`
`662`	`662`	`}`
`663`	`663`	`}`
`664`	`664`