strbuf: allocate space with GIT_MAX_HEXSZ

bk2204 · gitster · commit 4b048c917f9e · 2018-07-16T14:27:39.000-07:00
In order to be sure we have enough space to use with any hash algorithm,
use GIT_MAX_HEXSZ to allocate space.

Signed-off-by: brian m. carlson &lt;sandals@crustytoothpaste.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/strbuf.c b/strbuf.c
@@ -921,7 +921,7 @@ void strbuf_add_unique_abbrev(struct strbuf *sb, const struct object_id *oid,
 			      int abbrev_len)
 {
 	int r;
-	strbuf_grow(sb, GIT_SHA1_HEXSZ + 1);
+	strbuf_grow(sb, GIT_MAX_HEXSZ + 1);
 	r = find_unique_abbrev_r(sb->buf + sb->len, oid, abbrev_len);
 	strbuf_setlen(sb, sb->len + r);
 }

Original file line number	Diff line number	Diff line change
`@@ -921,7 +921,7 @@ void strbuf_add_unique_abbrev(struct strbuf sb, const struct object_id oid,`
`921`	`921`	`int abbrev_len)`
`922`	`922`	`{`
`923`	`923`	`int r;`
`924`		`- strbuf_grow(sb, GIT_SHA1_HEXSZ + 1);`
	`924`	`+ strbuf_grow(sb, GIT_MAX_HEXSZ + 1);`
`925`	`925`	`r = find_unique_abbrev_r(sb->buf + sb->len, oid, abbrev_len);`
`926`	`926`	`strbuf_setlen(sb, sb->len + r);`
`927`	`927`	`}`