revision: add leak_pending flag

René Scharfe · gitster · commit 4a43d374fcbd · 2011-10-03T11:04:34.000-07:00
The new flag leak_pending in struct rev_info can be used to prevent
prepare_revision_walk from freeing the list of pending objects.  It
will still forget about them, so it really is leaked.  This behaviour
may look weird at first, but it can be useful if the pointer to the
list is saved before calling prepare_revision_walk.

Signed-off-by: Rene Scharfe &lt;rene.scharfe@lsrfire.ath.cx&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/revision.c b/revision.c
@@ -1974,7 +1974,8 @@ int prepare_revision_walk(struct rev_info *revs)
 		}
 		e++;
 	}
-	free(list);
+	if (!revs->leak_pending)
+		free(list);
 
 	if (revs->no_walk)
 		return 0;
diff --git a/revision.h b/revision.h
@@ -97,6 +97,7 @@ struct rev_info {
 			date_mode_explicit:1,
 			preserve_subject:1;
 	unsigned int	disable_stdin:1;
+	unsigned int	leak_pending:1;
 
 	enum date_mode date_mode;
 

Original file line number	Diff line number	Diff line change
`@@ -1974,7 +1974,8 @@ int prepare_revision_walk(struct rev_info *revs)`
`1974`	`1974`	`}`
`1975`	`1975`	`e++;`
`1976`	`1976`	`}`
`1977`		`- free(list);`
	`1977`	`+ if (!revs->leak_pending)`
	`1978`	`+ free(list);`
`1978`	`1979`
`1979`	`1980`	`if (revs->no_walk)`
`1980`	`1981`	`return 0;`