parse-options.c: turn some die() to BUG()

pclouds · gitster · commit 48a5499ef50d · 2018-11-12T14:47:09.000+09:00
These two strings are clearly not for the user to see. Reduce the
violence in one string while at there.

Signed-off-by: Nguyễn Thái Ngọc Duy &lt;pclouds@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/parse-options.c b/parse-options.c
@@ -197,7 +197,7 @@ static int get_value(struct parse_opt_ctx_t *p,
 		return 0;
 
 	default:
-		die("should not happen, someone must be hit on the forehead");
+		BUG("opt->type %d should not happen", opt->type);
 	}
 }
 
@@ -424,7 +424,7 @@ void parse_options_start(struct parse_opt_ctx_t *ctx,
 	ctx->flags = flags;
 	if ((flags & PARSE_OPT_KEEP_UNKNOWN) &&
 	    (flags & PARSE_OPT_STOP_AT_NON_OPTION))
-		die("STOP_AT_NON_OPTION and KEEP_UNKNOWN don't go together");
+		BUG("STOP_AT_NON_OPTION and KEEP_UNKNOWN don't go together");
 	parse_options_check(options);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ static int get_value(struct parse_opt_ctx_t *p,`
`197`	`197`	`return 0;`
`198`	`198`
`199`	`199`	`default:`
`200`		`- die("should not happen, someone must be hit on the forehead");`
	`200`	`+ BUG("opt->type %d should not happen", opt->type);`
`201`	`201`	`}`
`202`	`202`	`}`
`203`	`203`
`@@ -424,7 +424,7 @@ void parse_options_start(struct parse_opt_ctx_t *ctx,`
`424`	`424`	`ctx->flags = flags;`
`425`	`425`	`if ((flags & PARSE_OPT_KEEP_UNKNOWN) &&`
`426`	`426`	`(flags & PARSE_OPT_STOP_AT_NON_OPTION))`
`427`		`- die("STOP_AT_NON_OPTION and KEEP_UNKNOWN don't go together");`
	`427`	`+ BUG("STOP_AT_NON_OPTION and KEEP_UNKNOWN don't go together");`
`428`	`428`	`parse_options_check(options);`
`429`	`429`	`}`
`430`	`430`