Merge branch 'jk/commit-edit-fixup-fix' into maint

gitster · gitster · commit 444b8548b1bb · 2021-10-12T13:51:38.000-07:00
"git commit --fixup" now works with "--edit" again, after it was
broken in v2.32.

* jk/commit-edit-fixup-fix:
  commit: restore --edit when combined with --fixup
diff --git a/builtin/commit.c b/builtin/commit.c
@@ -1253,8 +1253,6 @@ static int parse_and_validate_options(int argc, const char *argv[],
 
 	if (logfile || have_option_m || use_message)
 		use_editor = 0;
-	if (0 <= edit_flag)
-		use_editor = edit_flag;
 
 	/* Sanity check options */
 	if (amend && !current_head)
@@ -1344,6 +1342,9 @@ static int parse_and_validate_options(int argc, const char *argv[],
 		}
 	}
 
+	if (0 <= edit_flag)
+		use_editor = edit_flag;
+
 	cleanup_mode = get_cleanup_mode(cleanup_arg, use_editor);
 
 	handle_untracked_files_arg(s);
diff --git a/t/t7500-commit-template-squash-signoff.sh b/t/t7500-commit-template-squash-signoff.sh
@@ -270,7 +270,7 @@ EOF
 
 test_expect_success 'commit --fixup provides correct one-line commit message' '
 	commit_for_rebase_autosquash_setup &&
-	git commit --fixup HEAD~1 &&
+	EDITOR="echo ignored >>" git commit --fixup HEAD~1 &&
 	commit_msg_is "fixup! target message subject line"
 '
 
@@ -281,6 +281,13 @@ test_expect_success 'commit --fixup -m"something" -m"extra"' '
 
 extra"
 '
+test_expect_success 'commit --fixup --edit' '
+	commit_for_rebase_autosquash_setup &&
+	EDITOR="printf \"something\nextra\" >>" git commit --fixup HEAD~1 --edit &&
+	commit_msg_is "fixup! target message subject linesomething
+extra"
+'
+
 get_commit_msg () {
 	rev="$1" &&
 	git log -1 --pretty=format:"%B" "$rev"

Original file line number	Diff line number	Diff line change
`@@ -1253,8 +1253,6 @@ static int parse_and_validate_options(int argc, const char *argv[],`
`1253`	`1253`
`1254`	`1254`	`if (logfile \|\| have_option_m \|\| use_message)`
`1255`	`1255`	`use_editor = 0;`
`1256`		`- if (0 <= edit_flag)`
`1257`		`- use_editor = edit_flag;`
`1258`	`1256`
`1259`	`1257`	`/* Sanity check options */`
`1260`	`1258`	`if (amend && !current_head)`
`@@ -1344,6 +1342,9 @@ static int parse_and_validate_options(int argc, const char *argv[],`
`1344`	`1342`	`}`
`1345`	`1343`	`}`
`1346`	`1344`
	`1345`	`+ if (0 <= edit_flag)`
	`1346`	`+ use_editor = edit_flag;`
	`1347`	`+`
`1347`	`1348`	`cleanup_mode = get_cleanup_mode(cleanup_arg, use_editor);`
`1348`	`1349`
`1349`	`1350`	`handle_untracked_files_arg(s);`