add: remove ensure_full_index() with --renormalize

derrickstolee · gitster · commit 42f8ed6ca248 · 2021-07-29T12:36:34.000-07:00
The --renormalize option updates the EOL conversions for the tracked
files. However, the loop already ignores files marked with the
SKIP_WORKTREE bit, so it will continue to do so with a sparse index
because the sparse directory entries also have this bit set.

Reviewed-by: Elijah Newren &lt;newren@gmail.com&gt;
Signed-off-by: Derrick Stolee &lt;dstolee@microsoft.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/add.c b/builtin/add.c
@@ -144,8 +144,6 @@ static int renormalize_tracked_files(const struct pathspec *pathspec, int flags)
 {
 	int i, retval = 0;
 
-	/* TODO: audit for interaction with sparse-index. */
-	ensure_full_index(&the_index);
 	for (i = 0; i < active_nr; i++) {
 		struct cache_entry *ce = active_cache[i];
 

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,6 @@ static int renormalize_tracked_files(const struct pathspec *pathspec, int flags)`
`144`	`144`	`{`
`145`	`145`	`int i, retval = 0;`
`146`	`146`
`147`		`- /* TODO: audit for interaction with sparse-index. */`
`148`		`- ensure_full_index(&the_index);`
`149`	`147`	`for (i = 0; i < active_nr; i++) {`
`150`	`148`	`struct cache_entry *ce = active_cache[i];`
`151`	`149`