Skip to content

Commit 4165076

Browse files
schielegitster
authored andcommitted
install-sh from automake does not like -m without delimiting space
The install-sh script as shipped with automake requires a space between the -m switch and its argument. Since this is also the regular way of doing it with other install implementations this change inserts the missing space in all makefiles. Signed-off-by: Robert Schiele <rschiele@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 0f6f195 commit 4165076

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

Documentation/Makefile

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,16 @@ man7: $(DOC_MAN7)
7979
info: git.info
8080

8181
install: man
82-
$(INSTALL) -d -m755 $(DESTDIR)$(man1dir)
83-
$(INSTALL) -d -m755 $(DESTDIR)$(man5dir)
84-
$(INSTALL) -d -m755 $(DESTDIR)$(man7dir)
85-
$(INSTALL) -m644 $(DOC_MAN1) $(DESTDIR)$(man1dir)
86-
$(INSTALL) -m644 $(DOC_MAN5) $(DESTDIR)$(man5dir)
87-
$(INSTALL) -m644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
82+
$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
83+
$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
84+
$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
85+
$(INSTALL) -m 644 $(DOC_MAN1) $(DESTDIR)$(man1dir)
86+
$(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir)
87+
$(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
8888

8989
install-info: info
90-
$(INSTALL) -d -m755 $(DESTDIR)$(infodir)
91-
$(INSTALL) -m644 git.info $(DESTDIR)$(infodir)
90+
$(INSTALL) -d -m 755 $(DESTDIR)$(infodir)
91+
$(INSTALL) -m 644 git.info $(DESTDIR)$(infodir)
9292
if test -r $(DESTDIR)$(infodir)/dir; then \
9393
$(INSTALL_INFO) --info-dir=$(DESTDIR)$(infodir) git.info ;\
9494
else \

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1017,8 +1017,8 @@ remove-dashes:
10171017
### Installation rules
10181018

10191019
install: all
1020-
$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(bindir_SQ)'
1021-
$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
1020+
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
1021+
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
10221022
$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexecdir_SQ)'
10231023
$(INSTALL) git$X '$(DESTDIR_SQ)$(bindir_SQ)'
10241024
$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install

templates/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ clean:
4646
$(RM) -r blt boilerplates.made
4747

4848
install: all
49-
$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(template_dir_SQ)'
49+
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(template_dir_SQ)'
5050
(cd blt && $(TAR) cf - .) | \
5151
(cd '$(DESTDIR_SQ)$(template_dir_SQ)' && $(TAR) xf -)

0 commit comments

Comments
 (0)