archive-tar: don't reload default config options

peff · gitster · commit 40e7629194c7 · 2011-06-22T11:12:34.000-07:00
We load our own tar-specific config, and then chain to
git_default_config. This is pointless, as our caller should
already have loaded the default config. It also introduces a
needless inconsistency with the zip archiver, which does not
look at the config files at all (and therefore relies on the
caller to have loaded config).

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/archive-tar.c b/archive-tar.c
@@ -231,7 +231,7 @@ static int git_tar_config(const char *var, const char *value, void *cb)
 		}
 		return 0;
 	}
-	return git_default_config(var, value, cb);
+	return 0;
 }
 
 int write_tar_archive(struct archiver_args *args)

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ static int git_tar_config(const char var, const char value, void *cb)`
`231`	`231`	`}`
`232`	`232`	`return 0;`
`233`	`233`	`}`
`234`		`- return git_default_config(var, value, cb);`
	`234`	`+ return 0;`
`235`	`235`	`}`
`236`	`236`
`237`	`237`	`int write_tar_archive(struct archiver_args *args)`