config: make git_configset_get_string_tmp() private

derrickstolee · gitster · commit 3ce113827287 · 2022-02-08T09:49:21.000-08:00
This method was created in f1de981 (config: fix leaks from git_config_get_string_const(), 2020-08-14) but its only use was in the repo_config_get_string_tmp() method, also declared in config.h and implemented in config.c. Since this is otherwise unused and is a very similar implementation to git_configset_get_value(), let's remove this declaration. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Reviewed-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/config.c b/config.c
@@ -2179,8 +2179,8 @@ int git_configset_get_string(struct config_set *cs, const char *key, char **dest
 		return 1;
 }
 
-int git_configset_get_string_tmp(struct config_set *cs, const char *key,
-				 const char **dest)
+static int git_configset_get_string_tmp(struct config_set *cs, const char *key,
+					const char **dest)
 {
 	const char *value;
 	if (!git_configset_get_value(cs, key, &value)) {
diff --git a/config.h b/config.h
@@ -494,7 +494,6 @@ void git_configset_clear(struct config_set *cs);
 int git_configset_get_value(struct config_set *cs, const char *key, const char **dest);
 
 int git_configset_get_string(struct config_set *cs, const char *key, char **dest);
-int git_configset_get_string_tmp(struct config_set *cs, const char *key, const char **dest);
 int git_configset_get_int(struct config_set *cs, const char *key, int *dest);
 int git_configset_get_ulong(struct config_set *cs, const char *key, unsigned long *dest);
 int git_configset_get_bool(struct config_set *cs, const char *key, int *dest);

Original file line number	Diff line number	Diff line change
`@@ -2179,8 +2179,8 @@ int git_configset_get_string(struct config_set cs, const char key, char **dest`
`2179`	`2179`	`return 1;`
`2180`	`2180`	`}`
`2181`	`2181`
`2182`		`-int git_configset_get_string_tmp(struct config_set cs, const char key,`
`2183`		`- const char **dest)`
	`2182`	`+static int git_configset_get_string_tmp(struct config_set cs, const char key,`
	`2183`	`+ const char **dest)`
`2184`	`2184`	`{`
`2185`	`2185`	`const char *value;`
`2186`	`2186`	`if (!git_configset_get_value(cs, key, &value)) {`