helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo

chriscool · gitster · commit 3c27e2e05935 · 2019-01-17T10:55:03.000-08:00
It looks like it is a copy-paste error made in 80f2a60 (t/helper: add test-ref-store to test ref-store functions, 2017-03-26) to pass "old-sha1" instead of "new-sha1" to notnull() when we get the new sha1 argument from const char **argv. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Acked-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c
@@ -211,7 +211,7 @@ static int cmd_update_ref(struct ref_store *refs, const char **argv)
 {
 	const char *msg = notnull(*argv++, "msg");
 	const char *refname = notnull(*argv++, "refname");
-	const char *new_sha1_buf = notnull(*argv++, "old-sha1");
+	const char *new_sha1_buf = notnull(*argv++, "new-sha1");
 	const char *old_sha1_buf = notnull(*argv++, "old-sha1");
 	unsigned int flags = arg_flags(*argv++, "flags");
 	unsigned char old_sha1[20];

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ static int cmd_update_ref(struct ref_store refs, const char *argv)`
`211`	`211`	`{`
`212`	`212`	`const char msg = notnull(argv++, "msg");`
`213`	`213`	`const char refname = notnull(argv++, "refname");`
`214`		`- const char new_sha1_buf = notnull(argv++, "old-sha1");`
	`214`	`+ const char new_sha1_buf = notnull(argv++, "new-sha1");`
`215`	`215`	`const char old_sha1_buf = notnull(argv++, "old-sha1");`
`216`	`216`	`unsigned int flags = arg_flags(*argv++, "flags");`
`217`	`217`	`unsigned char old_sha1[20];`