Fix "git log --stat": make sure to set recursive with --stat.

Junio C Hamano · Junio C Hamano · commit 3a624b346db0 · 2006-04-18T11:43:09.000-07:00
Just like "patch" format always needs recursive, "diffstat"
format does not make sense without setting recursive.

Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/diff.c b/diff.c
@@ -1029,6 +1029,15 @@ int diff_setup_done(struct diff_options *options)
 	     options->detect_rename != DIFF_DETECT_COPY) ||
 	    (0 <= options->rename_limit && !options->detect_rename))
 		return -1;
+
+	/*
+	 * These cases always need recursive; we do not drop caller-supplied
+	 * recursive bits for other formats here.
+	 */
+	if ((options->output_format == DIFF_FORMAT_PATCH) ||
+	    (options->output_format == DIFF_FORMAT_DIFFSTAT))
+		options->recursive = 1;
+
 	if (options->detect_rename && options->rename_limit < 0)
 		options->rename_limit = diff_rename_limit_default;
 	if (options->setup & DIFF_SETUP_USE_CACHE) {
diff --git a/revision.c b/revision.c
@@ -791,8 +791,6 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
 		if (revs->dense_combined_merges)
 			revs->diffopt.output_format = DIFF_FORMAT_PATCH;
 	}
-	if (revs->diffopt.output_format == DIFF_FORMAT_PATCH)
-		revs->diffopt.recursive = 1;
 	revs->diffopt.abbrev = revs->abbrev;
 	diff_setup_done(&revs->diffopt);
 

Original file line number	Diff line number	Diff line change
`@@ -791,8 +791,6 @@ int setup_revisions(int argc, const char *argv, struct rev_info revs, const ch`
`791`	`791`	`if (revs->dense_combined_merges)`
`792`	`792`	`revs->diffopt.output_format = DIFF_FORMAT_PATCH;`
`793`	`793`	`}`
`794`		`- if (revs->diffopt.output_format == DIFF_FORMAT_PATCH)`
`795`		`- revs->diffopt.recursive = 1;`
`796`	`794`	`revs->diffopt.abbrev = revs->abbrev;`
`797`	`795`	`diff_setup_done(&revs->diffopt);`
`798`	`796`