Fix a small memory leak in builtin-add

tsuna · gitster · commit 399f0a8eedee · 2007-10-29T11:39:07.000-07:00
prune_directory and fill_directory allocated one byte per pathspec and never
freed it.

Signed-off-by: Benoit Sigoure &lt;tsuna@lrde.epita.fr&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-add.c b/builtin-add.c
@@ -44,6 +44,7 @@ static void prune_directory(struct dir_struct *dir, const char **pathspec, int p
 			die("pathspec '%s' did not match any files",
 					pathspec[i]);
 	}
+        free(seen);
 }
 
 static void fill_directory(struct dir_struct *dir, const char **pathspec,
@@ -140,6 +141,7 @@ static void refresh(int verbose, const char **pathspec)
 		if (!seen[i])
 			die("pathspec '%s' did not match any files", pathspec[i]);
 	}
+        free(seen);
 }
 
 static int git_add_config(const char *var, const char *value)

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ static void prune_directory(struct dir_struct dir, const char *pathspec, int p`
`44`	`44`	`die("pathspec '%s' did not match any files",`
`45`	`45`	`pathspec[i]);`
`46`	`46`	`}`
	`47`	`+ free(seen);`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`static void fill_directory(struct dir_struct dir, const char *pathspec,`
`@@ -140,6 +141,7 @@ static void refresh(int verbose, const char **pathspec)`
`140`	`141`	`if (!seen[i])`
`141`	`142`	`die("pathspec '%s' did not match any files", pathspec[i]);`
`142`	`143`	`}`
	`144`	`+ free(seen);`
`143`	`145`	`}`
`144`	`146`
`145`	`147`	`static int git_add_config(const char var, const char value)`