Merge branch 'mh/format-patch-add-header'

gitster · gitster · commit 37a13acb2e9e · 2009-04-01T22:49:24.000-07:00
* mh/format-patch-add-header:
  format-patch: add arbitrary email headers
diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
@@ -157,6 +157,11 @@ if that is not set.
 	Add a "Cc:" header to the email headers. This is in addition
 	to any configured headers, and may be used multiple times.
 
+--add-header=<header>::
+	Add an arbitrary header to the email headers.  This is in addition
+	to any configured headers, and may be used multiple times.
+	For example, --add-header="Organization: git-foo"
+
 --cover-letter::
 	In addition to the patches, generate a cover letter file
 	containing the shortlog and the overall diffstat.  You can
diff --git a/builtin-log.c b/builtin-log.c
@@ -918,6 +918,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
 			cover_letter = 1;
 		else if (!strcmp(argv[i], "--no-binary"))
 			no_binary_diff = 1;
+		else if (!prefixcmp(argv[i], "--add-header="))
+			add_header(argv[i] + 13);
 		else
 			argv[j++] = argv[i];
 	}
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
@@ -128,6 +128,21 @@ test_expect_success 'additional command line cc' '
 	grep "^ *S. E. Cipient <scipient@example.com>$" patch5
 '
 
+test_expect_success 'command line headers' '
+
+	git config --unset-all format.headers &&
+	git format-patch --add-header="Cc: R. E. Cipient <rcipient@example.com>" --stdout master..side | sed -e "/^$/q" >patch6 &&
+	grep "^Cc: R. E. Cipient <rcipient@example.com>$" patch6
+'
+
+test_expect_success 'configuration headers and command line headers' '
+
+	git config --replace-all format.headers "Cc: R. E. Cipient <rcipient@example.com>" &&
+	git format-patch --add-header="Cc: S. E. Cipient <scipient@example.com>" --stdout master..side | sed -e "/^$/q" >patch7 &&
+	grep "^Cc: R. E. Cipient <rcipient@example.com>,$" patch7 &&
+	grep "^ *S. E. Cipient <scipient@example.com>$" patch7
+'
+
 test_expect_success 'multiple files' '
 
 	rm -rf patches/ &&

Original file line number	Diff line number	Diff line change
`@@ -918,6 +918,8 @@ int cmd_format_patch(int argc, const char *argv, const char prefix)`
`918`	`918`	`cover_letter = 1;`
`919`	`919`	`else if (!strcmp(argv[i], "--no-binary"))`
`920`	`920`	`no_binary_diff = 1;`
	`921`	`+ else if (!prefixcmp(argv[i], "--add-header="))`
	`922`	`+ add_header(argv[i] + 13);`
`921`	`923`	`else`
`922`	`924`	`argv[j++] = argv[i];`
`923`	`925`	`}`