Skip to content

Commit 3644da7

Browse files
lilyballgitster
authored andcommitted
Make git-svn tests behave better on OS X
Give lib-git-svn.sh a few alternate paths to look for apache2. Explicitly define the LockFile so httpd will actually start under OS X Signed-off-by: Kevin Ballard <kevin@sb.org> Acked-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent bf7c902 commit 3644da7

File tree

1 file changed

+23
-2
lines changed

1 file changed

+23
-2
lines changed

t/lib-git-svn.sh

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,28 @@ poke() {
4949
test-chmtime +1 "$1"
5050
}
5151

52-
SVN_HTTPD_MODULE_PATH=${SVN_HTTPD_MODULE_PATH-'/usr/lib/apache2/modules'}
53-
SVN_HTTPD_PATH=${SVN_HTTPD_PATH-'/usr/sbin/apache2'}
52+
for d in \
53+
"$SVN_HTTPD_PATH" \
54+
/usr/sbin/apache2 \
55+
/usr/sbin/httpd \
56+
; do
57+
if test -f "$d"
58+
then
59+
SVN_HTTPD_PATH="$d"
60+
break
61+
fi
62+
done
63+
for d in \
64+
"$SVN_HTTPD_MODULE_PATH" \
65+
/usr/lib/apache2/modules \
66+
/usr/libexec/apache2 \
67+
; do
68+
if test -d "$d"
69+
then
70+
SVN_HTTPD_MODULE_PATH="$d"
71+
break
72+
fi
73+
done
5474

5575
start_httpd () {
5676
if test -z "$SVN_HTTPD_PORT"
@@ -66,6 +86,7 @@ ServerName "git-svn test"
6686
ServerRoot "$GIT_DIR"
6787
DocumentRoot "$GIT_DIR"
6888
PidFile "$GIT_DIR/httpd.pid"
89+
LockFile logs/accept.lock
6990
Listen 127.0.0.1:$SVN_HTTPD_PORT
7091
LoadModule dav_module $SVN_HTTPD_MODULE_PATH/mod_dav.so
7192
LoadModule dav_svn_module $SVN_HTTPD_MODULE_PATH/mod_dav_svn.so

0 commit comments

Comments
 (0)