http-backend: Let gcc check the format of more printf-type functions.

Tarmigan Casebolt · gitster · commit 354870171bc9 · 2009-11-15T22:15:01.000-08:00
We already have these checks in many printf-type functions that have
prototypes which are in header files.  Add these same checks to
static functions in http-backend.c

Signed-off-by: Tarmigan Casebolt &lt;tarmigan+git@gmail.com&gt;
Acked-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/http-backend.c b/http-backend.c
@@ -108,6 +108,7 @@ static const char *get_parameter(const char *name)
 	return i ? i->util : NULL;
 }
 
+__attribute__((format (printf, 2, 3)))
 static void format_write(int fd, const char *fmt, ...)
 {
 	static char buffer[1024];
@@ -165,6 +166,7 @@ static void end_headers(void)
 	safe_write(1, "\r\n", 2);
 }
 
+__attribute__((format (printf, 1, 2)))
 static NORETURN void not_found(const char *err, ...)
 {
 	va_list params;
@@ -180,6 +182,7 @@ static NORETURN void not_found(const char *err, ...)
 	exit(0);
 }
 
+__attribute__((format (printf, 1, 2)))
 static NORETURN void forbidden(const char *err, ...)
 {
 	va_list params;

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ static const char get_parameter(const char name)`
`108`	`108`	`return i ? i->util : NULL;`
`109`	`109`	`}`
`110`	`110`
	`111`	`+__attribute__((format (printf, 2, 3)))`
`111`	`112`	`static void format_write(int fd, const char *fmt, ...)`
`112`	`113`	`{`
`113`	`114`	`static char buffer[1024];`
`@@ -165,6 +166,7 @@ static void end_headers(void)`
`165`	`166`	`safe_write(1, "\r\n", 2);`
`166`	`167`	`}`
`167`	`168`
	`169`	`+__attribute__((format (printf, 1, 2)))`
`168`	`170`	`static NORETURN void not_found(const char *err, ...)`
`169`	`171`	`{`
`170`	`172`	`va_list params;`
`@@ -180,6 +182,7 @@ static NORETURN void not_found(const char *err, ...)`
`180`	`182`	`exit(0);`
`181`	`183`	`}`
`182`	`184`
	`185`	`+__attribute__((format (printf, 1, 2)))`
`183`	`186`	`static NORETURN void forbidden(const char *err, ...)`
`184`	`187`	`{`
`185`	`188`	`va_list params;`