sha1_file: improve sha1_file_name() perfs

chriscool · gitster · commit 3449847168c9 · 2018-01-19T13:21:49.000-08:00
As sha1_file_name() could be performance sensitive, let's
make it faster by using strbuf_addstr() and strbuf_addc()
instead of strbuf_addf().

Helped-by: Derrick Stolee &lt;stolee@gmail.com&gt;
Helped-by: Jeff Hostetler &lt;git@jeffhostetler.com&gt;
Signed-off-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/sha1_file.c b/sha1_file.c
@@ -253,8 +253,8 @@ static void fill_sha1_path(struct strbuf *buf, const unsigned char *sha1)
 
 void sha1_file_name(struct strbuf *buf, const unsigned char *sha1)
 {
-	strbuf_addf(buf, "%s/", get_object_directory());
-
+	strbuf_addstr(buf, get_object_directory());
+	strbuf_addch(buf, '/');
 	fill_sha1_path(buf, sha1);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -253,8 +253,8 @@ static void fill_sha1_path(struct strbuf buf, const unsigned char sha1)`
`253`	`253`
`254`	`254`	`void sha1_file_name(struct strbuf buf, const unsigned char sha1)`
`255`	`255`	`{`
`256`		`- strbuf_addf(buf, "%s/", get_object_directory());`
`257`		`-`
	`256`	`+ strbuf_addstr(buf, get_object_directory());`
	`257`	`+ strbuf_addch(buf, '/');`
`258`	`258`	`fill_sha1_path(buf, sha1);`
`259`	`259`	`}`
`260`	`260`