git wrapper: fix command name in an error message.

ageric · Junio C Hamano · commit 33ebb8717f15 · 2006-06-28T03:20:51.000-07:00
When the command execution by execv_git_cmd() fails with an errno
other than ENOENT, we used an uninitialized variable instead of
the string that holds the command name to report what failed.

Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/git.c b/git.c
@@ -206,7 +206,6 @@ int main(int argc, const char **argv, char **envp)
 {
 	const char *cmd = argv[0];
 	char *slash = strrchr(cmd, '/');
-	char git_command[PATH_MAX + 1];
 	const char *exec_path = NULL;
 	int done_alias = 0;
 
@@ -313,7 +312,7 @@ int main(int argc, const char **argv, char **envp)
 		cmd_usage(0, exec_path, "'%s' is not a git-command", cmd);
 
 	fprintf(stderr, "Failed to run command '%s': %s\n",
-		git_command, strerror(errno));
+		cmd, strerror(errno));
 
 	return 1;
 }

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,6 @@ int main(int argc, const char argv, char envp)`
`206`	`206`	`{`
`207`	`207`	`const char *cmd = argv[0];`
`208`	`208`	`char *slash = strrchr(cmd, '/');`
`209`		`- char git_command[PATH_MAX + 1];`
`210`	`209`	`const char *exec_path = NULL;`
`211`	`210`	`int done_alias = 0;`
`212`	`211`
`@@ -313,7 +312,7 @@ int main(int argc, const char argv, char envp)`
`313`	`312`	`cmd_usage(0, exec_path, "'%s' is not a git-command", cmd);`
`314`	`313`
`315`	`314`	`fprintf(stderr, "Failed to run command '%s': %s\n",`
`316`		`- git_command, strerror(errno));`
	`315`	`+ cmd, strerror(errno));`
`317`	`316`
`318`	`317`	`return 1;`
`319`	`318`	`}`