Git.pm: fix return value of config method

Lea Wiemann · gitster · commit 32d8050a86f8 · 2008-06-01T22:28:27.000-07:00
If config is called in array context, it is supposed to return all
values set for the given option key.  This works for all cases except
if there is no value set at all.  In that case, it wrongly returns
(undef) instead of ().  This fixes the return statement so that it
returns undef in scalar context but an empty array in array context.

Signed-off-by: Lea Wiemann &lt;LeWiemann@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/perl/Git.pm b/perl/Git.pm
@@ -565,7 +565,7 @@ sub config {
 		my $E = shift;
 		if ($E->value() == 1) {
 			# Key not found.
-			return undef;
+			return;
 		} else {
 			throw $E;
 		}

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ sub config {`
`565`	`565`	`my $E = shift;`
`566`	`566`	`if ($E->value() == 1) {`
`567`	`567`	`# Key not found.`
`568`		`- return undef;`
	`568`	`+ return;`
`569`	`569`	`} else {`
`570`	`570`	`throw $E;`
`571`	`571`	`}`