builtin-clone: use strbuf in guess_dir_name()

Miklos Vajna · gitster · commit 32716a2c6c23 · 2008-11-25T15:34:25.000-08:00
Signed-off-by: Miklos Vajna &lt;vmiklos@frugalware.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-clone.c b/builtin-clone.c
@@ -134,9 +134,9 @@ static char *guess_dir_name(const char *repo, int is_bundle, int is_bare)
 	}
 
 	if (is_bare) {
-		char *result = xmalloc(end - start + 5);
-		sprintf(result, "%.*s.git", (int)(end - start), start);
-		return result;
+		struct strbuf result = STRBUF_INIT;
+		strbuf_addf(&result, "%.*s.git", (int)(end - start), start);
+		return strbuf_detach(&result, 0);
 	}
 
 	return xstrndup(start, end - start);

Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,9 @@ static char guess_dir_name(const char repo, int is_bundle, int is_bare)`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`if (is_bare) {`
`137`		`- char *result = xmalloc(end - start + 5);`
`138`		`- sprintf(result, "%.*s.git", (int)(end - start), start);`
`139`		`- return result;`
	`137`	`+ struct strbuf result = STRBUF_INIT;`
	`138`	`+ strbuf_addf(&result, "%.*s.git", (int)(end - start), start);`
	`139`	`+ return strbuf_detach(&result, 0);`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`return xstrndup(start, end - start);`