bisect--helper: use '-res' in 'cmd_bisect__helper' return

mirucam · gitster · commit 30276765c114 · 2020-08-28T16:21:16.000-07:00
Following 'enum bisect_error' vocabulary, return variable 'res' is
always non-positive.
Let's use '-res' instead of 'abs(res)' to make the code clearer.

Mentored-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Helped-by: Junio C Hamano &lt;gitster@pobox.com&gt;
Signed-off-by: Miriam Rubio &lt;mirucam@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
@@ -731,5 +731,5 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 	if (res == BISECT_INTERNAL_SUCCESS_MERGE_BASE)
 		res = BISECT_OK;
 
-	return abs(res);
+	return -res;
 }

Original file line number	Diff line number	Diff line change
`@@ -731,5 +731,5 @@ int cmd_bisect__helper(int argc, const char *argv, const char prefix)`
`731`	`731`	`if (res == BISECT_INTERNAL_SUCCESS_MERGE_BASE)`
`732`	`732`	`res = BISECT_OK;`
`733`	`733`
`734`		`- return abs(res);`
	`734`	`+ return -res;`
`735`	`735`	`}`