t7508: avoid non-portable sed expression

sunshineco · gitster · commit 2e582df0e0f1 · 2013-09-17T10:17:33.000-07:00
2556b99 (status: disable display of '#' comment prefix by default; 2013-09-06) introduced tests which fail on Mac OS X due to unportable use of \t (for TAB) in a sed expression. POSIX [1][2] also disallows it. Fix this. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html#tag_20_116_13_02 [2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_03_02 Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Acked-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/t7508-status.sh b/t/t7508-status.sh
@@ -61,7 +61,8 @@ test_expect_success 'status (1)' '
 '
 
 strip_comments () {
-	sed "s/^\# //; s/^\#$//; s/^#\t/\t/" <"$1" >"$1".tmp &&
+	tab='	'
+	sed "s/^\# //; s/^\#$//; s/^#$tab/$tab/" <"$1" >"$1".tmp &&
 	rm "$1" && mv "$1".tmp "$1"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,8 @@ test_expect_success 'status (1)' '`
`61`	`61`	`'`
`62`	`62`
`63`	`63`	`strip_comments () {`
`64`		`- sed "s/^\# //; s/^\#$//; s/^#\t/\t/" <"$1" >"$1".tmp &&`
	`64`	`+ tab=' '`
	`65`	`+ sed "s/^\# //; s/^\#$//; s/^#$tab/$tab/" <"$1" >"$1".tmp &&`
`65`	`66`	`rm "$1" && mv "$1".tmp "$1"`
`66`	`67`	`}`
`67`	`68`