fix: Use of uninitialized value

Kay Sievers · Kay Sievers · commit 2c5c008b462f · 2006-01-17T03:50:20.000+01:00
The subroutine did not check the case where HEAD does not verify.

Patch from Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/gitweb.cgi b/gitweb.cgi
@@ -404,12 +404,13 @@ sub git_read_head {
 	if (open my $fd, "-|", "$gitbin/git-rev-parse", "--verify", "HEAD") {
 		my $head = <$fd>;
 		close $fd;
-		chomp $head;
-		if ($head =~ m/^[0-9a-fA-F]{40}$/) {
-			$retval = $head;
+		if (defined $head && $head =~ /^([0-9a-fA-F]{40})$/) {
+			$retval = $1;
 		}
 	}
-	$ENV{'GIT_DIR'} = $oENV;
+	if (defined $oENV) {
+		$ENV{'GIT_DIR'} = $oENV;
+	}
 	return $retval;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -404,12 +404,13 @@ sub git_read_head {`
`404`	`404`	`if (open my $fd, "-\|", "$gitbin/git-rev-parse", "--verify", "HEAD") {`
`405`	`405`	`my $head = <$fd>;`
`406`	`406`	`close $fd;`
`407`		`- chomp $head;`
`408`		`- if ($head =~ m/^[0-9a-fA-F]{40}$/) {`
`409`		`- $retval = $head;`
	`407`	`+ if (defined $head && $head =~ /^([0-9a-fA-F]{40})$/) {`
	`408`	`+ $retval = $1;`
`410`	`409`	`}`
`411`	`410`	`}`
`412`		`- $ENV{'GIT_DIR'} = $oENV;`
	`411`	`+ if (defined $oENV) {`
	`412`	`+ $ENV{'GIT_DIR'} = $oENV;`
	`413`	`+ }`
`413`	`414`	`return $retval;`
`414`	`415`	`}`
`415`	`416`