t7401: add a NEEDSWORK

periperidip · gitster · commit 2a0d1a5ce2a9 · 2020-08-21T11:47:56.000-07:00
Add a NEEDSWORK regarding the outdated syntax and working of the test,
which may need to be improved to obtain better and desired results.

While at it, change the word 'test' to 'test script' in the test
description to avoid ambiguity.

Mentored-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Mentored-by: Kaartic Sivaraam &lt;kaartic.sivaraam@gmail.com&gt;
Helped-by: Taylor Blau &lt;me@ttaylorr.com&gt;
Signed-off-by: Shourya Shukla &lt;shouryashukla.oo@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh
@@ -5,8 +5,11 @@
 
 test_description='Summary support for submodules
 
-This test tries to verify the sanity of summary subcommand of git submodule.
+This test script tries to verify the sanity of summary subcommand of git submodule.
 '
+# NEEDSWORK: This test script is old fashioned and may need a big cleanup due to
+# various reasons, one of them being that there are lots of commands taking place
+# outside of 'test_expect_success' block, which is no longer in good-style.
 
 . ./test-lib.sh
 

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,11 @@`
`5`	`5`
`6`	`6`	`test_description='Summary support for submodules`
`7`	`7`
`8`		`-This test tries to verify the sanity of summary subcommand of git submodule.`
	`8`	`+This test script tries to verify the sanity of summary subcommand of git submodule.`
`9`	`9`	`'`
	`10`	`+# NEEDSWORK: This test script is old fashioned and may need a big cleanup due to`
	`11`	`+# various reasons, one of them being that there are lots of commands taking place`
	`12`	`+# outside of 'test_expect_success' block, which is no longer in good-style.`
`10`	`13`
`11`	`14`	`. ./test-lib.sh`
`12`	`15`