builtin-fetch: Don't segfault on "fetch +foo"

spearce · gitster · commit 27e13374bf18 · 2007-09-19T03:22:31.000-07:00
If we are fetching something and were configured to do a forced
fetch and have no local ref to store the fetched object into we
cannot mark the local ref as having a forced update.  Instead we
should just silently discard the + request.

Signed-off-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
diff --git a/remote.c b/remote.c
@@ -875,8 +875,7 @@ int get_fetch_map(struct ref *remote_refs,
 					 refspec->src : "HEAD");
 
 		ref_map->peer_ref = get_local_ref(refspec->dst);
-
-		if (refspec->force)
+		if (ref_map->peer_ref && refspec->force)
 			ref_map->peer_ref->force = 1;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -875,8 +875,7 @@ int get_fetch_map(struct ref *remote_refs,`
`875`	`875`	`refspec->src : "HEAD");`
`876`	`876`
`877`	`877`	`ref_map->peer_ref = get_local_ref(refspec->dst);`
`878`		`-`
`879`		`- if (refspec->force)`
	`878`	`+ if (ref_map->peer_ref && refspec->force)`
`880`	`879`	`ref_map->peer_ref->force = 1;`
`881`	`880`	`}`
`882`	`881`