completion: use 'sort -u' to deduplicate config variable names

szeder · gitster · commit 2675ea1cc0f5 · 2019-08-13T12:31:04.000-07:00
The completion script runs the classic '| sort | uniq' pipeline to
deduplicate the output of 'git help --config-for-completion'.  'sort
-u' does the same, but uses one less external process and pipeline
stage.  Not a bit win, as it's only run once as the list of supported
configuration variables is initialized, but at least it sets a better
example for others to follow.

Signed-off-by: SZEDER Gábor &lt;szeder.dev@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
@@ -2225,7 +2225,7 @@ __git_config_vars=
 __git_compute_config_vars ()
 {
 	test -n "$__git_config_vars" ||
-	__git_config_vars="$(git help --config-for-completion | sort | uniq)"
+	__git_config_vars="$(git help --config-for-completion | sort -u)"
 }
 
 _git_config ()

Original file line number	Diff line number	Diff line change
`@@ -2225,7 +2225,7 @@ __git_config_vars=`
`2225`	`2225`	`__git_compute_config_vars ()`
`2226`	`2226`	`{`
`2227`	`2227`	`test -n "$__git_config_vars" \|\|`
`2228`		`- __git_config_vars="$(git help --config-for-completion \| sort \| uniq)"`
	`2228`	`+ __git_config_vars="$(git help --config-for-completion \| sort -u)"`
`2229`	`2229`	`}`
`2230`	`2230`
`2231`	`2231`	`_git_config ()`