terminal: always reset terminal when reading without echo

phillipwood · gitster · commit 24d7ce383a3d · 2022-02-23T13:30:06.000-08:00
Break out of the loop to ensure restore_term() is called before
returning.

Signed-off-by: Phillip Wood &lt;phillip.wood@dunelm.org.uk&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/compat/terminal.c b/compat/terminal.c
@@ -385,7 +385,7 @@ int read_key_without_echo(struct strbuf *buf)
 
 			ch = getchar();
 			if (ch == EOF)
-				return 0;
+				break;
 			strbuf_addch(buf, ch);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ int read_key_without_echo(struct strbuf *buf)`
`385`	`385`
`386`	`386`	`ch = getchar();`
`387`	`387`	`if (ch == EOF)`
`388`		`- return 0;`
	`388`	`+ break;`
`389`	`389`	`strbuf_addch(buf, ch);`
`390`	`390`	`}`
`391`	`391`	`}`