Skip to content

Commit 1f73862

Browse files
committed
Clarify why we can't do 'git rev-list' with a path.
1 parent 86de04c commit 1f73862

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

git-subtree.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,9 @@ cmd_split()
338338
unrevs="$(find_existing_splits "$dir" "$revs")"
339339
fi
340340

341-
# We can't restrict rev-list to only "$dir" here, because that leaves out
342-
# critical information about commit parents.
343-
debug "git rev-list --reverse --parents $revs $unrevs"
341+
# We can't restrict rev-list to only $dir here, because some of our
342+
# parents have the $dir contents the root, and those won't match.
343+
# (and rev-list --follow doesn't seem to solve this)
344344
git rev-list --reverse --parents $revs $unrevs |
345345
while read rev parents; do
346346
debug

0 commit comments

Comments
 (0)