sha1_to_hex: properly terminate the SHA1

dscho · Junio C Hamano · commit 1e80e0449248 · 2005-12-22T12:52:37.000-08:00
sha1_to_hex() returns a pointer to a static buffer. Some of its users
modify that buffer by appending a newline character. Other users rely
on the fact that you can call

	printf("%s", sha1_to_hex(sha1));

Just to be on the safe side, terminate the SHA1 in sha1_to_hex().

Signed-off-by: Johannes Schindelin &lt;Johannes.Schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/sha1_file.c b/sha1_file.c
@@ -81,6 +81,8 @@ char * sha1_to_hex(const unsigned char *sha1)
 		*buf++ = hex[val >> 4];
 		*buf++ = hex[val & 0xf];
 	}
+	*buf = '\0';
+
 	return buffer;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,8 @@ char * sha1_to_hex(const unsigned char *sha1)`
`81`	`81`	`*buf++ = hex[val >> 4];`
`82`	`82`	`*buf++ = hex[val & 0xf];`
`83`	`83`	`}`
	`84`	`+ *buf = '\0';`
	`85`	`+`
`84`	`86`	`return buffer;`
`85`	`87`	`}`
`86`	`88`