refs API: make refs_ref_exists() not set errno

avar · gitster · commit 1e3ccb552f3d · 2021-10-16T11:17:04.000-07:00
Move refs_ref_exists from the legacy refs_resolve_ref_unsafe() to the
new refs_werrres_ref_unsafe(). I have read its callers and determined
that they don't care about errno being set, in particular:

    git grep -W -w -e refs_ref_exists -e ref_exists

Signed-off-by: Ævar Arnfjörð Bjarmason &lt;avarab@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -309,7 +309,9 @@ int read_ref(const char *refname, struct object_id *oid)
 
 int refs_ref_exists(struct ref_store *refs, const char *refname)
 {
-	return !!refs_resolve_ref_unsafe(refs, refname, RESOLVE_REF_READING, NULL, NULL);
+	int ignore_errno;
+	return !!refs_werrres_ref_unsafe(refs, refname, RESOLVE_REF_READING,
+					 NULL, NULL, &ignore_errno);
 }
 
 int ref_exists(const char *refname)

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,9 @@ int read_ref(const char refname, struct object_id oid)`
`309`	`309`
`310`	`310`	`int refs_ref_exists(struct ref_store refs, const char refname)`
`311`	`311`	`{`
`312`		`- return !!refs_resolve_ref_unsafe(refs, refname, RESOLVE_REF_READING, NULL, NULL);`
	`312`	`+ int ignore_errno;`
	`313`	`+ return !!refs_werrres_ref_unsafe(refs, refname, RESOLVE_REF_READING,`
	`314`	`+ NULL, NULL, &ignore_errno);`
`313`	`315`	`}`
`314`	`316`
`315`	`317`	`int ref_exists(const char *refname)`