git_mkstemps_mode: don't set errno to EINVAL on exit.

moy · gitster · commit 1d9740cb324f · 2010-02-22T15:24:46.000-08:00
When reaching the end of git_mkstemps_mode, at least one call to open()
has been done, and errno has been set accordingly. Setting errno is
therefore not necessary, and actually harmfull since callers can't
distinguish e.g. permanent failure from ENOENT, which can just mean that
we need to create the containing directory.

Signed-off-by: Matthieu Moy &lt;Matthieu.Moy@imag.fr&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/path.c b/path.c
@@ -222,7 +222,6 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode)
 	}
 	/* We return the null string if we can't find a unique file name.  */
 	pattern[0] = '\0';
-	errno = EINVAL;
 	return -1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,6 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode)`
`222`	`222`	`}`
`223`	`223`	`/* We return the null string if we can't find a unique file name. */`
`224`	`224`	`pattern[0] = '\0';`
`225`		`- errno = EINVAL;`
`226`	`225`	`return -1;`
`227`	`226`	`}`
`228`	`227`