send-email: squelch warning due to comparing undefined $_ to ""

jaysoffian · gitster · commit 1ca3d6ed0177 · 2008-02-20T02:47:54.000-08:00
The check to see if initial_reply_to is defined was also comparing $_ to
"" for a reason I cannot ascertain (looking at the commit which made the
change didn't provide enlightenment), but if $_ is undefined, perl
generates a warning.

Signed-off-by: Jay Soffian &lt;jaysoffian@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-send-email.perl b/git-send-email.perl
@@ -406,7 +406,7 @@ sub expand_aliases {
 
 	$initial_reply_to = $_;
 }
-if (defined $initial_reply_to && $_ ne "") {
+if (defined $initial_reply_to) {
 	$initial_reply_to =~ s/^\s*<?/</;
 	$initial_reply_to =~ s/>?\s*$/>/;
 }

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ sub expand_aliases {`
`406`	`406`
`407`	`407`	`$initial_reply_to = $_;`
`408`	`408`	`}`
`409`		`-if (defined $initial_reply_to && $_ ne "") {`
	`409`	`+if (defined $initial_reply_to) {`
`410`	`410`	`$initial_reply_to =~ s/^\s*<?/</;`
`411`	`411`	`$initial_reply_to =~ s/>?\s*$/>/;`
`412`	`412`	`}`