Skip to content

Commit 1b2486d

Browse files
sprohaskagitster
authored andcommitted
push: teach push to pass --verbose option to transport layer
A --verbose option to push should also be passed to the transport layer, i.e. git-send-pack, git-http-push. git push is modified to do so. Signed-off-by: Steffen Prohaska <prohaska@zib.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 05ee917 commit 1b2486d

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

builtin-push.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)
115115
flags |= TRANSPORT_PUSH_FORCE;
116116
if (dry_run)
117117
flags |= TRANSPORT_PUSH_DRY_RUN;
118+
if (verbose)
119+
flags |= TRANSPORT_PUSH_VERBOSE;
118120
if (tags)
119121
add_refspec("refs/tags/*");
120122
if (all)

transport.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ static int curl_transport_push(struct transport *transport, int refspec_nr, cons
386386
int argc;
387387
int err;
388388

389-
argv = xmalloc((refspec_nr + 11) * sizeof(char *));
389+
argv = xmalloc((refspec_nr + 12) * sizeof(char *));
390390
argv[0] = "http-push";
391391
argc = 1;
392392
if (flags & TRANSPORT_PUSH_ALL)
@@ -395,6 +395,8 @@ static int curl_transport_push(struct transport *transport, int refspec_nr, cons
395395
argv[argc++] = "--force";
396396
if (flags & TRANSPORT_PUSH_DRY_RUN)
397397
argv[argc++] = "--dry-run";
398+
if (flags & TRANSPORT_PUSH_VERBOSE)
399+
argv[argc++] = "--verbose";
398400
argv[argc++] = transport->url;
399401
while (refspec_nr--)
400402
argv[argc++] = *refspec++;
@@ -655,7 +657,7 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
655657
int argc;
656658
int err;
657659

658-
argv = xmalloc((refspec_nr + 11) * sizeof(char *));
660+
argv = xmalloc((refspec_nr + 12) * sizeof(char *));
659661
argv[0] = "send-pack";
660662
argc = 1;
661663
if (flags & TRANSPORT_PUSH_ALL)
@@ -664,6 +666,8 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
664666
argv[argc++] = "--force";
665667
if (flags & TRANSPORT_PUSH_DRY_RUN)
666668
argv[argc++] = "--dry-run";
669+
if (flags & TRANSPORT_PUSH_VERBOSE)
670+
argv[argc++] = "--verbose";
667671
if (data->receivepack) {
668672
char *rp = xmalloc(strlen(data->receivepack) + 16);
669673
sprintf(rp, "--receive-pack=%s", data->receivepack);

transport.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ struct transport {
3030
#define TRANSPORT_PUSH_ALL 1
3131
#define TRANSPORT_PUSH_FORCE 2
3232
#define TRANSPORT_PUSH_DRY_RUN 4
33+
#define TRANSPORT_PUSH_VERBOSE 8
3334

3435
/* Returns a transport suitable for the url */
3536
struct transport *transport_get(struct remote *, const char *);

0 commit comments

Comments
 (0)