diff.c: rearrange xcalloc arguments

modocache · gitster · commit 1a4927c5c54f · 2014-05-27T14:02:03.000-07:00
xcalloc() takes two arguments: the number of elements and their size.
diffstat_add() passes the arguments in reverse order, passing the
size of a diffstat_file*, followed by the number of diffstat_file* to
be allocated.

Rearrange them so they are in the correct order.

Signed-off-by: Brian Gesiak &lt;modocache@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/diff.c b/diff.c
@@ -1361,7 +1361,7 @@ static struct diffstat_file *diffstat_add(struct diffstat_t *diffstat,
 					  const char *name_b)
 {
 	struct diffstat_file *x;
-	x = xcalloc(sizeof (*x), 1);
+	x = xcalloc(1, sizeof(*x));
 	ALLOC_GROW(diffstat->files, diffstat->nr + 1, diffstat->alloc);
 	diffstat->files[diffstat->nr++] = x;
 	if (name_b) {

Original file line number	Diff line number	Diff line change
`@@ -1361,7 +1361,7 @@ static struct diffstat_file diffstat_add(struct diffstat_t diffstat,`
`1361`	`1361`	`const char *name_b)`
`1362`	`1362`	`{`
`1363`	`1363`	`struct diffstat_file *x;`
`1364`		`- x = xcalloc(sizeof (*x), 1);`
	`1364`	`+ x = xcalloc(1, sizeof(*x));`
`1365`	`1365`	`ALLOC_GROW(diffstat->files, diffstat->nr + 1, diffstat->alloc);`
`1366`	`1366`	`diffstat->files[diffstat->nr++] = x;`
`1367`	`1367`	`if (name_b) {`