Skip to content

Commit 1a36552

Browse files
devzero2000gitster
authored andcommitted
contrib/examples/git-merge.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent cc301d7 commit 1a36552

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

contrib/examples/git-merge.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -523,10 +523,10 @@ do
523523

524524
if test "$exit" -eq 1
525525
then
526-
cnt=`{
526+
cnt=$({
527527
git diff-files --name-only
528528
git ls-files --unmerged
529-
} | wc -l`
529+
} | wc -l)
530530
if test $best_cnt -le 0 || test $cnt -le $best_cnt
531531
then
532532
best_strategy=$strategy

0 commit comments

Comments
 (0)