git-svn: clone: Fail on missing url argument

clayne · Eric Wong · commit 19e9542fa29e · 2016-07-03T06:04:47.000Z
cmd_clone should detect a missing $url arg before using it otherwise
an uninitialized value error is emitted in even the simplest case of
'git svn clone' without arguments.

Signed-off-by: Christopher Layne &lt;clayne@anodized.com&gt;
Signed-off-by: Eric Wong &lt;e@80x24.org&gt;
diff --git a/git-svn.perl b/git-svn.perl
@@ -507,7 +507,10 @@ sub init_subdir {
 
 sub cmd_clone {
 	my ($url, $path) = @_;
-	if (!defined $path &&
+	if (!$url) {
+		die "SVN repository location required ",
+		    "as a command-line argument\n";
+	} elsif (!defined $path &&
 	    (defined $_trunk || @_branches || @_tags ||
 	     defined $_stdlayout) &&
 	    $url !~ m#^[a-z\+]+://#) {
