bash completion: complete refs for git-grep

trast · gitster · commit 17225c49d501 · 2009-10-12T16:13:19.000-07:00
Before the --, always attempt ref completion.  This helps with
entering the &lt;treeish&gt; arguments to git-grep.  As a bonus, you can
work around git-grep's current lack of --all by hitting M-*, ugly as
the resulting command line may be.

Strictly speaking, completing the regular expression argument (or
option argument) makes no sense.  However, we cannot prevent _all_
completion (it will fall back to filenames), so we dispense with any
additional complication to detect whether the user still has to enter
a regular expression.

Signed-off-by: Thomas Rast &lt;trast@student.ethz.ch&gt;
Acked-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
@@ -1069,7 +1069,8 @@ _git_grep ()
 		return
 		;;
 	esac
-	COMPREPLY=()
+
+	__gitcomp "$(__git_refs)"
 }
 
 _git_help ()

Original file line number	Diff line number	Diff line change
`@@ -1069,7 +1069,8 @@ _git_grep ()`
`1069`	`1069`	`return`
`1070`	`1070`	`;;`
`1071`	`1071`	`esac`
`1072`		`- COMPREPLY=()`
	`1072`	`+`
	`1073`	`+ __gitcomp "$(__git_refs)"`
`1073`	`1074`	`}`
`1074`	`1075`
`1075`	`1076`	`_git_help ()`